Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloudwatch: Add missing AWS/IVS namespace metrics #65985

Merged
merged 2 commits into from Apr 6, 2023
Merged

Cloudwatch: Add missing AWS/IVS namespace metrics #65985

merged 2 commits into from Apr 6, 2023
+1 −1

Conversation

idastambuk
Copy link
Contributor

What is this feature?

Adds missing namsepace metrics to the dropdown, as reported in #65819

Which issue(s) does this PR fix?:

Fixes #65819

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@idastambuk idastambuk added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Apr 5, 2023
@idastambuk idastambuk added this to the 10.0.0 milestone Apr 5, 2023
@idastambuk idastambuk requested a review from a team as a code owner April 5, 2023 08:20
@idastambuk idastambuk requested review from fridgepoet and kevinwcyu and removed request for a team April 5, 2023 08:20
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Backend code coverage report for PR #65985

Plugin Main PR Difference
cloudwatch 82.4% 82.4% 0%

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Frontend code coverage report for PR #65985
No changes

@idastambuk idastambuk added add to changelog and removed no-changelog Skip including change in changelog/release notes labels Apr 6, 2023
@idastambuk idastambuk merged commit 2648fcb into main Apr 6, 2023
22 checks passed
@idastambuk idastambuk deleted the 65819-cloudwatch-add-missing-metrics-to-awsivs-namespace branch April 6, 2023 07:52
@zerok zerok modified the milestones: 10.0.0, 10.0.0-preview May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinwcyu kevinwcyu kevinwcyu approved these changes

@fridgepoet fridgepoet Awaiting requested review from fridgepoet fridgepoet is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
add to changelog area/backend datasource/CloudWatch no-backport Skip backport of PR
Projects
None yet
Milestone
10.0.0-preview
Development

Successfully merging this pull request may close these issues.

Cloudwatch: add missing metrics to AWS/IVS namespace
4 participants
@idastambuk @kevinwcyu @zerok @grafanabot