Tempo: Encode IDs as hexadecimal when downloading traces

[kousikmitra]

What is this feature?

While downloading traces as json the ids are getting converted to base64. This change will remove the conversion and export ids in hex format instead. So that encoding remain consistent across.

Why do we need this feature?

[Add a description of the problem the feature is trying to solve.]

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #63003

Special notes for your reviewer:

Please check that:

• It works as expected from a user's perspective.
• If this is a pre-GA feature, it is behind a feature toggle.
• The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

[github-advanced-security]

You have successfully added a new CodeQL configuration .github/workflows/pr-codeql-analysis-javascript.yml:analyze. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

[adrapereira]

LGTM! Thanks for the contribution @kousikmitra

[adrapereira]

There's actually a couple of issues, sorry!

Apart from my comment you also need to fix this test:

FAIL public/app/plugins/datasource/tempo/datasource.test.ts (22.543 s)
  ● Tempo data source › should handle json file upload

    expect(received).toBe(expected) // Object.is equality

    Expected: "60ba2abb44f13eae"
    Received: "RPE+rg=="

      197 |     expect(field.name).toBe('traceID');
      198 |     expect(field.type).toBe(FieldType.string);
    > 199 |     expect(field.values.get(0)).toBe('60ba2abb44f13eae');
          |                                 ^
      200 |     expect(field.values.length).toBe(6);
      201 |   });
      202 |

      at public/app/plugins/datasource/tempo/datasource.test.ts:199:33

[adrapereira]

There's a typo here, it should be span.traceId.

Suggested change

	traceID: span.traceId.length > 16 ? span.traceId.slice(16) : span.traceID,
	traceID: span.traceId.length > 16 ? span.traceId.slice(16) : span.traceId,

[kousikmitra]

my bad, fixed.

[kousikmitra]

Updated the mock json data.

After this change the expectation for importing tempo trace from json is, the json data should have traceID, spanID and parentSpanId all in hex format instead of base64.

[adrapereira]

Thank you for the changes, approved!