Instrumentation: Add support for instrumenting database queries #66022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergquist
added
no-backport
bergquist
force-pushed
the
database_metrics_setting
branch
from
10494b0
to
f9a3a88
Compare
bergquist
requested review from
papagian,
zserge and
mildwonkey
and removed request for
a team
bergquist
added
add to changelog
and removed
no-changelog
bergquist
changed the title
|
ping @papagian :) |
papagian
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
sorry I missed the ping!
Need to update the docs and remove the feature toggle as well
Signed-off-by: bergquist <carl.bergquist@gmail.com>
Signed-off-by: bergquist <carl.bergquist@gmail.com>
Signed-off-by: bergquist <carl.bergquist@gmail.com>
Signed-off-by: bergquist <carl.bergquist@gmail.com>
bergquist
force-pushed
the
database_metrics_setting
branch
from
5dcfce7
to
5253dec
Compare
bergquist
added
the
levitate breaking change
Signed-off-by: bergquist <carl.bergquist@gmail.com>
bergquist
removed
the
levitate breaking change
chri2547
reviewed
Apr 28, 2023
chri2547
reviewed
Apr 28, 2023
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
ryantxu
pushed a commit
that referenced
this pull request
May 3, 2023
Signed-off-by: bergquist <carl.bergquist@gmail.com> Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature toggle was added in #29662 and forgotten. It's about time we make it a grafana ini setting instead of a feature toggle :)
Closes #65989