Elasticsearch: Add feature toggle to disable running queries trough backend #66260
Conversation
ivanahuckova
added
datasource/Elasticsearch
add to changelog
no-backport
ivanahuckova
requested review from
joshhunt,
JoaoSilvaGrafana,
andresmgot,
papagian,
mildwonkey,
yangkb09 and
a team
and removed request for
a team,
joshhunt,
papagian,
andresmgot,
mildwonkey,
yangkb09 and
JoaoSilvaGrafana
ivanahuckova
requested review from
mckn
and removed request for
a team and
mckn
|
(Open the links below in a new tab to go to the correct steps)
|
grafanabot
added
the
levitate breaking change
ivanahuckova
removed
the
levitate breaking change
|
Backend code coverage report for PR #66260 |
|
Frontend code coverage report for PR #66260
|
grafanabot
added
the
levitate breaking change
| | `emptyDashboardPage` | Enable the redesigned user interface of a dashboard page that includes no panels | Yes | | ||
| | `disablePrometheusExemplarSampling` | Disable Prometheus exemplar sampling | | | ||
| | `logsSampleInExplore` | Enables access to the logs sample feature in Explore | Yes | | ||
| | `disableElasticsearchBackendQuerying` | Disable processing of queries and responses in Elasticsearch data source trough backend | | |
There was a problem hiding this comment.
| | `disableElasticsearchBackendQuerying` | Disable processing of queries and responses in Elasticsearch data source trough backend | | | |
| | `disableElasticsearchBackendQuerying` | Disable the processing of queries and responses in the Elasticsearch data source through backend | | |
There was a problem hiding this comment.
@ivanahuckova , I'm unsure of what 'through backend' means. Can you please explain, and I can help with adjusting the words. Thank you!
There was a problem hiding this comment.
@chri2547 currently we are processing Elasticsearch queries and responses in typescript (on frontend). We are moving logic for processing queries and responses to data source backend in golang. This change should not be visible for users (we did extensive testing), but because processing of both - queries and responses is quite complex, there might be cases when processed response might have slight differences that can (in edge cases) break dashboards. In that case we recommend using this feature toggle to disable running queries torugh backend and we ask users to create a github issue to improve the experience and fix the issue.
There was a problem hiding this comment.
@ivanahuckova, interesting - and thank you for the thorough description. How will a user know that this feature toggle is available and that they should create a GH issue to improve the experience?
There was a problem hiding this comment.
We will:
- Communicating this change via #elk channel in community slack
- Part of changelog
If you have any other suggestions, let me know!
…ackend (#66260) * Elasticsearch: Create feature toggle to disable running queries trough backend * Fix frontend tests running trough frontend * Update description of feature toggle
In this PR, we are adding
disableElasticsearchBackendQueryingfeature toggle to disable running queries trough backend for Grafana 10 release. It also removeselasticsearchBackendMigrationadded for development purpose anddisableElasticsearchBackendExploreQueryadded for 9.5 to give user a way to disable running of Explore queries trough backend.Part of #54011