Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Monitor: Fix bug that was not showing resources for certain locations #66502

Merged
merged 4 commits into from Apr 14, 2023
Merged

Azure Monitor: Fix bug that was not showing resources for certain locations #66502

merged 4 commits into from Apr 14, 2023

Conversation

alyssabull
Copy link
Contributor

Azure Monitor currently automatically retrieves locations based on a users subscriptions. This PR fixes a bug where the locations were not all being retrieved by eliminating unnecessary filtering.

Fixes #63890

@alyssabull alyssabull added type/bug datasource/Azure Azure Monitor Datasource add to changelog backport v9.4.x Mark PR for automatic backport to v9.4.x labels Apr 13, 2023
@alyssabull alyssabull added this to the 10.0.0 milestone Apr 13, 2023
@alyssabull alyssabull self-assigned this Apr 13, 2023
@alyssabull alyssabull requested a review from a team as a code owner April 13, 2023 17:12
@alyssabull alyssabull requested review from asimpson and bossinc and removed request for a team April 13, 2023 17:12
@alyssabull alyssabull changed the title Azure Monitor: Fix bug that was not showing all resources for certain locations Azure Monitor: Fix bug that was not showing resources for certain locations Apr 13, 2023
@github-actions
Copy link
Contributor

Backend code coverage report for PR #66502
No changes

@github-actions
Copy link
Contributor

github-actions bot commented Apr 13, 2023 •
edited

Frontend code coverage report for PR #66502

Plugin Main PR Difference
azuremonitor 82.98% 82.91% -.07%

aangelisc
aangelisc approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this! I tested locally and it seems the default dashboards are working fine. Just a couple comments to address 😊

asimpson
asimpson approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@asimpson asimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! 🏆

@alyssabull alyssabull merged commit d43482a into main Apr 14, 2023
13 checks passed
@alyssabull alyssabull deleted the fix-azure-monitor-resource-bug branch April 14, 2023 19:47
@grafanabot grafanabot mentioned this pull request Apr 14, 2023
Merged
grafanabot pushed a commit that referenced this pull request Apr 14, 2023
@alyssabull @grafanabot
Azure Monitor: Fix bug that was not showing resources for certain loc…
240a4ce 
…ations (#66502)

(cherry picked from commit d43482a)
@aangelisc aangelisc mentioned this pull request Apr 17, 2023
Closed
@aangelisc aangelisc added the backport v9.5.x Bot will automatically open backport PR label Apr 25, 2023
@grafanabot grafanabot mentioned this pull request Apr 25, 2023
Merged
grafanabot pushed a commit that referenced this pull request Apr 25, 2023
@alyssabull @grafanabot
Azure Monitor: Fix bug that was not showing resources for certain loc…
fab8b9e 
…ations (#66502)

(cherry picked from commit d43482a)
aangelisc pushed a commit that referenced this pull request Apr 25, 2023
@grafanabot @alyssabull
[v9.5.x] Azure Monitor: Fix bug that was not showing resources for ce…
92fa914 
…rtain locations (#67216)

Azure Monitor: Fix bug that was not showing resources for certain locations (#66502)

(cherry picked from commit d43482a)

Co-authored-by: Alyssa Bull <58453566+alyssabull@users.noreply.github.com>
aangelisc pushed a commit that referenced this pull request Apr 26, 2023
@grafanabot @alyssabull
[v9.4.x] Azure Monitor: Fix bug that was not showing resources for ce…
ded351d 
…rtain locations (#66617)

Azure Monitor: Fix bug that was not showing resources for certain locations (#66502)

(cherry picked from commit d43482a)

Co-authored-by: Alyssa Bull <58453566+alyssabull@users.noreply.github.com>
@zerok zerok modified the milestones: 10.0.0, 10.0.0-preview May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asimpson asimpson asimpson approved these changes

@aangelisc aangelisc aangelisc approved these changes

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

Assignees

@alyssabull alyssabull

Labels
add to changelog area/frontend backport v9.4.x Mark PR for automatic backport to v9.4.x backport v9.5.x Bot will automatically open backport PR datasource/Azure Azure Monitor Datasource type/bug
Projects
Partner Datasources
Status: Done
Milestone
10.0.0-preview
Development

Successfully merging this pull request may close these issues.

Azure datasource the resource selector doesn't work with westus3 region
5 participants
@alyssabull @asimpson @aangelisc @zerok @grafanabot