Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loki: Fix ad hoc filters when used with number and > and < operators #66579

Merged
merged 1 commit into from Apr 17, 2023

Conversation

ivanahuckova
Copy link
Member

When using ad hoc filters with > and < operators and numbers, we should add them as numbers and not as strings.

Example of fixed query with > operator and number:

image

Example of fixed query with > operator and not number:

image

Fixes: #64172

@github-actions
Copy link
Contributor

Backend code coverage report for PR #66579
No changes

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023

Frontend code coverage report for PR #66579

Plugin Main PR Difference
loki 84.68% 84.68% 0%

@ivanahuckova ivanahuckova reopened this Apr 17, 2023
@github-actions github-actions bot removed this from the 10.0.0 milestone Apr 17, 2023
@ivanahuckova ivanahuckova merged commit 2509dec into main Apr 17, 2023
29 checks passed
@ivanahuckova ivanahuckova deleted the ivana/loki-ad-hoc-number branch April 17, 2023 08:27
adela-almasan pushed a commit that referenced this pull request Apr 17, 2023
…66579)

Loki: Fix ad hoc filters when used with number and >< operators
@zerok zerok added this to the 10.0.0 milestone May 3, 2023
@zerok zerok modified the milestones: 10.0.0, 10.0.0-preview May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LOKI: Ad hoc filters are not working for integer values
4 participants