-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: Fix library panels in collapsed rows not getting updated #66643
Conversation
Ping @juanicabanas @evictorero |
Hi @juanicabanas @evictorero (maybe @torkelo as well)! Is there a hold up on this PR? This is a pretty damaging bug for anyone who uses library panels and rows at the same time. |
yes, I think this should be backported |
Hi @VictorColomb! I tested and it is working as expected. I'm not sure about backporting it though, I will ask the team for another look at this change because I don't have enough context about the side effect that this change could have. |
I know it does in no way guarantee correct behavior, but to add some context, I forked main before the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-66643-to-v9.5.x origin/v9.5.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x f478504bc9f8cdf84cb53f0cfd8d521b398aa7e7
# Push it to GitHub
git push --set-upstream origin backport-66643-to-v9.5.x
git switch main
# Remove the local backport branch
git branch -D backport-66643-to-v9.5.x Then, create a pull request where the |
What is this feature?
This PR unifies the way that library panels are saved in a dashboard JSON, whether the library panel is in a collapsed row or not.
In practice, this PR modifies the way that a library panel inside a collapsed row gets saved.
Why do we need this feature?
Library panels in collapsed rows are currently not being cleaned into the format just above and are therefore being saved with their model hardcoded. This means that they are not updated when the library panel has a new version (see attached issue below).
Who is this feature for?
Everyone!
Which issue(s) does this PR fix?:
Fixes #66640
Special notes for your reviewer:
Please check that: