Trace View: Update the queryType to traceql for checking if same trace when clicking span link #66645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when clicking span link
grafanabot
added
area/explore
area/frontend
pr/external
adrapereira
requested changes
Apr 17, 2023
adrapereira
added
add to changelog
backport v9.4.x
|
Hello @adrapereira!
Please, if the current pull request addresses a bug fix, label it with the |
adrapereira
changed the title
adrapereira
changed the title
adrapereira
changed the title
adela-almasan
pushed a commit
that referenced
this pull request
Apr 17, 2023
…e when clicking span link (#66645) * TraceView: update the queryType to traceql for checking if same trace when clicking span link * TraceView: linting * TraceView: remove traceid check completely
adrapereira
pushed a commit
that referenced
this pull request
Apr 18, 2023
…same trace when clicking span link (#66670) Trace View: Update the queryType to traceql for checking if same trace when clicking span link (#66645) * TraceView: update the queryType to traceql for checking if same trace when clicking span link * TraceView: linting * TraceView: remove traceid check completely (cherry picked from commit 6462c81) Co-authored-by: Eric Mustin <mustin.eric@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR is a bug fix for the TraceView component. When clicking a trace span's "links", a split pane was always opening even if the span belonged to the same trace. The intended behavior is to only open a new pane if it's a different trace.
As far as i can tell from git history, this is a regression is part of the migration to the
traceqltab from thetraceidtab (see: #60180). This work enabled thetraceqltab to also be used for individual trace lookup/viewing individual traces + the PR hid thetraceidtab. Looks like a line was just missed for updating queryType fromtraceidtotraceqlas part of that work. Reviewing the tests it seems like this should just betraceql, but I've tried to introduce this gracefully (support both comparing a check for queryTypetraceqlandtraceidwhen deciding whether a new pane should be opened for a span link) in case any folks have already built custom monkeypatches assumingtraceid.We just picked this up on the upgrade to 9.4 and are already running this patch in production without issue, for context.
Why do we need this feature?
[Add a description of the problem the feature is trying to solve.]
Who is this feature for?
folks using opentelemetry span links or other similar styles of relationship between traces.
Which issue(s) does this PR fix?:
n/a, i can open an issue demonstrating the problem but this is pretty straightforward imo.
Special notes for your reviewer:
Please check that: