New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connections: Simplify connections nav #66813
Conversation
Thanks for opening this @torkelo! 👍 I think technically this change is not complicated, we have to pay attention to change things in other places accordingly as you said. I also agree that we should update the URLs (and the nav-ids), too, to keep the code in a consistent state. Changes required in other places
Another (important) question: Also summoning @mikkancso and @jarben. |
I think that's the critical question. WDYT about adding that config to the default Grafana config? That way probably we wouldn't have to synchronize the config update in Hosted-Grafana-API with the release. I'm gonna ask the Grafana SaaS team about this. |
Once https://github.com/grafana/hosted-grafana/issues/3859 is done, we should be fine and we can move forward with this PR. |
@mikkancso isn't this already supported here? Or could we just use Also this change may affect this issue in hg-cloud-home-admin. @yduartep I'd suggest to wait with implementing this issue after G10. Looks like the current redirect in the plugin will handle this change without an issue @mikkancso ? We also need to update the PDC plugin to reflect this, cc @fabienne-m |
I have not worked on this issue yet because I have seen that there is an automatic redirect and then I wanted to wait for a complete rollout of the nav. In any case, I will wait after Grafana 10 to see what happens. Thanks for the update @jarben . |
Thanks, I haven't realized that. I think we should go with your latter suggestion.
Yeah, I think we can prepare the plugin to redirect to the correct url based on the Grafana version. I'll look into this now in depth. |
I updated this PR with the renaming of the URLs, component names and navIDs. |
@mikkancso @leventebalogh so when can we merge this? |
I think we can merge this as soon as checks pass on this PR |
Hello @torkelo!
Please, if the current pull request addresses a bug fix, label it with the |
* Connections: Simplify connections nav * rename Connections pages everywhere --------- Co-authored-by: Miklós Tolnai <miklos.tolnai@grafana.com> (cherry picked from commit 9614dc2)
Slack thread: https://raintank-corp.slack.com/archives/C034LMXLXQU/p1681835191084819
As discussed over slack this simplifies and flattens the nav hierarchy in Connections
Could need help from the connections devs (@leventebalogh ?) to complete this PR as it might need changes in plugins (and in plugin nav config).
I also did not change any urls in this PR (they still include /your-connections) I think it might be good to change those as well. And the connect data page that was renamed is connect-data in URL as I assume that is referenced by a plugin config to override that URL.