Expressions/threshold: Fix incorrect thresholds args length #66859
+77
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gillesdemey
added
type/bug
area/alerting
Overlaps with other testcases
grafanabot
pushed a commit
that referenced
this pull request
Apr 20, 2023
(cherry picked from commit 350de3f)
grafanabot
pushed a commit
that referenced
this pull request
Apr 20, 2023
(cherry picked from commit 350de3f)
gillesdemey
added a commit
that referenced
this pull request
Apr 20, 2023
gillesdemey
added a commit
that referenced
this pull request
Apr 20, 2023
mdvictor
pushed a commit
that referenced
this pull request
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
When using a threshold expression with fewer than the required number of args, it would panic because it accessed a non-existing index of the slice.
Why do we need this feature?
This fix returns a sensible error and does not dump a stack trace to the logs.
Special notes for your reviewer:
Steps to reproduce