Elasticsearch: Use array of strings as index in backend queries #67276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanahuckova
added
datasource/Elasticsearch
type/refactor
no-backport
|
Backend code coverage report for PR #67276
|
|
Frontend code coverage report for PR #67276 |
gabor
reviewed
Apr 26, 2023
| @@ -207,7 +207,7 @@ func (c *baseClientImpl) createMultiSearchRequests(searchRequests []*SearchReque | |||
| header: map[string]interface{}{ | |||
| "search_type": "query_then_fetch", | |||
| "ignore_unavailable": true, | |||
| "index": strings.Join(c.indices, ","), | |||
| "index": c.indices, | |||
This was referenced Jul 10, 2023
gabor
added a commit
that referenced
this pull request
Jul 11, 2023
gabor
added a commit
that referenced
this pull request
Jul 11, 2023
…ted string (#71322) Elasticsearch: Fix using multiple indexes with comma separated string (#71284) * Revert "Elasticsearch: Use array of strings as index in backend queries (#67276)" This reverts commit d0ced39. * updated tests (cherry picked from commit e17540b) Co-authored-by: Gábor Farkas <gabor.farkas@gmail.com>
polibb
pushed a commit
that referenced
this pull request
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #54011
Based on https://www.elastic.co/guide/en/elasticsearch/reference/current/search-multi-search.html#search-multi-search-api-request-body we are changing index in backend request's header to be array of strings, rather then comma separated list.
The test have been updated.
To test, run queries and ensure that they are working.