Toolkit: Remove deprecated plugin:build
#67485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
academo
added
add to changelog
breaking change
academo
requested review from
ashharrison90 and
mckn
and removed request for
a team
academo
added
backport
academo
changed the title
build:pluginplugin:build
ashharrison90
approved these changes
Apr 28, 2023
| "prepack": "mv ./src ./src_bak && cp -r ./dist/src ./src", | ||
| "postpack": "rimraf ./src && mv ./src_bak ./src", | ||
| "postpack": "rm -rf ./src && mv ./src_bak ./src", |
There was a problem hiding this comment.
does this have any implications for windows machines? believe that's the whole reason for including rimraf. or do we not care since it's now removed? 🤔
There was a problem hiding this comment.
The scripts are already using mv (see prepack) which doesn't work on windows and we support windows under WSL https://grafana.com/blog/2021/03/03/how-to-set-up-a-grafana-development-environment-on-a-windows-pc-using-wsl/
tolzhabayev
approved these changes
Apr 28, 2023
ryantxu
pushed a commit
that referenced
this pull request
May 3, 2023
Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Removes the deprecated
plugin:buildcommand from toolkit.Why do we need this feature?
We are moving all plugin-related commands from toolkit to create-plugin.
Who is this feature for?
All plugin developers
Which issue(s) does this PR fix?:
Closes: #57750
Related to: #55997
Fixes #
Special notes for your reviewer:
Please check that:
Release notice breaking change
The deprecated
plugin:buildcommand in the Grafana Toolkit have been removed in this release. The replacementcreate-plugintool is recommended for plugin development.