Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard: Revert fixed header shown on mobile devices in the new panel header #67510

Merged
merged 2 commits into from Apr 28, 2023
Merged

Dashboard: Revert fixed header shown on mobile devices in the new panel header #67510

merged 2 commits into from Apr 28, 2023

Conversation

axelavargas
Copy link
Member

@axelavargas axelavargas commented Apr 28, 2023 •
edited

What is this feature?

Reverting the fixed header on mobile devices. This approach was proposed as a way to improve a11y for screen readers but overlooked the aesthetics and UX aspects. We need to rethink how to address the a11y issue.

Old Behavior

image

New Behavior

NewBehavior.mp4

Who is this feature for?

Everyone

Which issue(s) does this PR fix?:

Fixes #67322

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@axelavargas axelavargas added type/bug add to changelog backport v9.5.x Bot will automatically open backport PR labels Apr 28, 2023
@axelavargas axelavargas added this to the 9.5.x milestone Apr 28, 2023
@axelavargas axelavargas self-assigned this Apr 28, 2023
@axelavargas axelavargas requested a review from a team as a code owner April 28, 2023 13:50
@axelavargas axelavargas requested review from joshhunt and eledobleefe and removed request for a team April 28, 2023 13:50
@axelavargas axelavargas requested review from dprokop, a team and juanicabanas and removed request for a team, joshhunt and eledobleefe April 28, 2023 13:51
@axelavargas axelavargas changed the title New PanelHeader: Revert Fixed header shown on mobile devices PanelHeader: Revert Fixed header shown on mobile devices Apr 28, 2023
@axelavargas axelavargas changed the title PanelHeader: Revert Fixed header shown on mobile devices Dashboard : Revert fixed header shown on mobile devices in the new panel header Apr 28, 2023
@axelavargas axelavargas changed the title Dashboard : Revert fixed header shown on mobile devices in the new panel header Dashboard: Revert fixed header shown on mobile devices in the new panel header Apr 28, 2023
@axelavargas axelavargas merged commit 07041b5 into main Apr 28, 2023
17 checks passed
@axelavargas axelavargas deleted the axelav/revert-fixed-header-mobile branch April 28, 2023 14:20
@grafanabot grafanabot mentioned this pull request Apr 28, 2023
Merged
grafanabot pushed a commit that referenced this pull request Apr 28, 2023
@axelavargas @grafanabot
Dashboard: Revert fixed header shown on mobile devices in the new pan…
6a1078f 
…el header (#67510)

(cherry picked from commit 07041b5)
axelavargas pushed a commit that referenced this pull request Apr 28, 2023
@grafanabot
[v9.5.x] Dashboard: Revert fixed header shown on mobile devices in th…
5bc27fd 
…e new panel header (#67514)

Co-authored-by: Alexa V <239999+axelavargas@users.noreply.github.com>
fixed header shown on mobile devices in the new panel header (#67510)
@zerok zerok modified the milestones: 9.5.x, 9.5.2 May 3, 2023
@zerok zerok modified the milestones: 9.5.2, 10.0.0 May 3, 2023
ryantxu pushed a commit that referenced this pull request May 3, 2023
@axelavargas @ryantxu
Dashboard: Revert fixed header shown on mobile devices in the new pan…
7bb7f91 
…el header (#67510)
@zerok zerok modified the milestones: 10.0.0, 10.0.0-preview May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprokop dprokop dprokop approved these changes

@juanicabanas juanicabanas juanicabanas approved these changes

Assignees

@axelavargas axelavargas

Labels
add to changelog area/frontend backport v9.5.x Bot will automatically open backport PR type/bug
Projects
None yet
Milestone
10.0.0-preview
Development

Successfully merging this pull request may close these issues.

PanelHeader: Fixed header in shown on mobile devices
5 participants
@axelavargas @dprokop @juanicabanas @zerok @grafanabot