Tempo: Integrate context aware autocomplete API #67845
Conversation
adrapereira
added
area/frontend
add to changelog
area/datasource/frontend
datasource/Tempo
no-backport
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
grafanabot
added
stale
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
grafanabot
added
stale
…utocomplete_traceql_api # Conflicts: # public/app/plugins/datasource/tempo/SearchTraceQLEditor/SearchField.tsx # public/app/plugins/datasource/tempo/language_provider.ts # public/app/plugins/datasource/tempo/traceql/autocomplete.ts
|
@grafana/observability-traces-and-profiling Would appreciate a review! |
There was a problem hiding this comment.
Noticed that the API uses double quotes around the query but we do not here. I'd imagine that's an older example of the API that has since been updated so probably no issue.
Overall I like what the API is doing, however there is a use case where the user has created a query that returns few values or no values for a tag, and the user is not quite sure why. If there are no values we show No options found in the drop down. I thin this can be improved in another PR to make a note of sorts so the user knows that removing parts of their query could result in more options.
|
Thanks for the review @joey-grafana! Yeah, I tested this against the API and it was working without quotes, but thank you for bringing it up. That's a good idea, it's not immediately clear that there are no options because of the context around it. I'll create an issue for it. |
* Send query in search tag values call * Make sure to send the full query when using the code editor * Fix merge conflicts * Remove unused params
* Send query in search tag values call * Make sure to send the full query when using the code editor * Fix merge conflicts * Remove unused params
What is this feature?
This PR integrates the new context aware autocomplete API from Tempo, by sending the full query in the
qparameter of theapi/v2/search/tags/.../valuesendpoint.It also removes some unused code in the Tempo language provider.
Why do we need this feature?
We want to use the existing query to filter down the possible values for new tags and help the users write valid queries faster.
Who is this feature for?
All users of the Tempo datasource.
Which issue(s) does this PR fix?:
Fixes #66956
Special notes for your reviewer:
Please check that: