RBAC: Remove legacy AC editor and admin role on new dashboard route #68762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleijonmarck
added
add to changelog
backport v9.4.x
eleijonmarck
requested review from
joshhunt and
eledobleefe
and removed request for
a team
gamab
approved these changes
May 22, 2023
|
Yea they are aware of that. It will be fixed from the dashboard squad this week |
eleijonmarck
changed the title
3 tasks
ryantxu
pushed a commit
that referenced
this pull request
May 22, 2023
…68762) remove legacy AC editor and admin role on new dashboard route
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Why do we need this feature?
When RBAC is disabled and you grant a edit permission for viewers in a folder. they are unable to create a new dashboard as it is protected by the orgRoles 'Editor', 'Admin'. This removes this constraints
This allows viewers, even without dashboard permissions, to access the routes. It would enable them to create dashboards but not save them thx to the permissions on the backend.
Who is this feature for?
Azuregrafanasupport
Which issue(s) does this PR fix?: