-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TimeSeries: Add zoom-out functionality on double click #68936
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanks! there's a https://github.com/leeoniya/uPlot/blob/master/dist/uPlot.d.ts#L437 via: |
nmarrs
added
area/panel/timeseries
The main time series Graph panel
add to changelog
no-backport
Skip backport of PR
labels
May 23, 2023
we can also roll this into the existing ZoomPlugin, not sure how useful it is to keep it split off. |
simPod
changed the title
TimeSeries: Add ZoomOutPlugin
ZoomPlugin: Add zoom-out functionality on double click
May 24, 2023
I think I have addressed your comments. |
did you try #68936 (comment) instead of this? config.addHook('setCursor', (u) => {
u.over.ondblclick = () => { |
leeoniya
reviewed
May 24, 2023
packages/grafana-ui/src/components/uPlot/plugins/ZoomPlugin.tsx
Outdated
Show resolved
Hide resolved
simPod
commented
May 24, 2023
packages/grafana-ui/src/components/uPlot/plugins/ZoomPlugin.tsx
Outdated
Show resolved
Hide resolved
leeoniya
approved these changes
May 26, 2023
leeoniya
changed the title
ZoomPlugin: Add zoom-out functionality on double click
TimeSeries: Add zoom-out functionality on double click
May 26, 2023
grobinson-grafana
pushed a commit
that referenced
this pull request
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to changelog
area/frontend
area/panel/timeseries
The main time series Graph panel
no-backport
Skip backport of PR
pr/external
This PR is from external contributor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
When double clicking in Graph panel chart area, the timerange is zoomed out. This double-click feature was missing in TimeSeries and this PR adds it.
Why do we need this feature?
This brings feature parity with old Graph panel
Special notes for your reviewer:
Please check that: