New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: Fix provenance guard checks for Alertmanager configuration to not cause panic when compared nested objects #69009
Alerting: Fix provenance guard checks for Alertmanager configuration to not cause panic when compared nested objects #69009
Conversation
Hello @yuri-tceretian!
Please, if the current pull request addresses a bug fix, label it with the |
Hello @yuri-tceretian!
Please, if the current pull request addresses a bug fix, label it with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
…iguration to not cause panic when compared nested objects (#69094) Alerting: Fix provenance guard checks for Alertmanager configuration to not cause panic when compared nested objects (#69009) * fix current settings parsed as new * replace map comparison with cmp.Diff and log the diff (cherry picked from commit e002604) Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>
…guration to not cause panic when compared nested objects (#69092) Alerting: Fix provenance guard checks for Alertmanager configuration to not cause panic when compared nested objects (#69009) * fix current settings parsed as new * replace map comparison with cmp.Diff and log the diff (cherry picked from commit e002604) Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>
…to not cause panic when compared nested objects (#69009) * fix current settings parsed as new * replace map comparison with cmp.Diff and log the diff
What is this feature?
This PR fixes a panic that is caused when the provenance guard compares the settings of the current and submitted integrations that contain nested objects.
Why do we need this feature?
Currently, this makes it impossible to update non-provisioned contact points via regular API if the configuration contains provisioned PagerDuty integration. The request will cause panic
Who is this feature for?
Users who provision PagerDuty integration because it is the only one that accepts nested objects in settings.
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: