Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfluxDB: Interpolate retention policies #69202

Merged
merged 1 commit into from May 31, 2023

Conversation

itsmylife
Copy link
Contributor

What is this feature?

In the current state of InfluxDB data source, we are not interpolating the retention policies.
This PR is addressing that.

Why do we need this feature?

To be able to use retention policies as variables.

Who is this feature for?

InfluxDB users

Which issue(s) does this PR fix?:

Fixes #67602

How to test

  • Create a dashboard with a variable with the query SHOW RETENTION POLICIES
  • In the panel select the variable in the retention policy dropdown
  • In the network tab observe the query call. See that the selected retention policy is being used.
  • Change the retention policy variable. Observe the new retention policy is being used in the query

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@itsmylife itsmylife added this to the 9.5.x milestone May 27, 2023
@itsmylife itsmylife requested a review from a team as a code owner May 27, 2023 00:05
@grafanabot
Copy link
Contributor

Hello @itsmylife!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@grafanabot
Copy link
Contributor

Hello @itsmylife!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

Copy link
Contributor

@bohandley bohandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@itsmylife itsmylife merged commit f610e37 into main May 31, 2023
27 checks passed
@itsmylife itsmylife deleted the ismail/influxdb-retention-policy-variable branch May 31, 2023 10:04
grafanabot pushed a commit that referenced this pull request May 31, 2023
Interpolate retention policies

(cherry picked from commit f610e37)
grafanabot pushed a commit that referenced this pull request May 31, 2023
Interpolate retention policies

(cherry picked from commit f610e37)
itsmylife added a commit that referenced this pull request May 31, 2023
InfluxDB: Interpolate retention policies (#69202)

Interpolate retention policies

(cherry picked from commit f610e37)

Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>
itsmylife added a commit that referenced this pull request May 31, 2023
InfluxDB: Interpolate retention policies (#69202)

Interpolate retention policies

(cherry picked from commit f610e37)

Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>
@zerok zerok modified the milestones: 9.5.x, 10.1.x Jun 29, 2023
@itsmylife itsmylife added the backport v9.4.x Mark PR for automatic backport to v9.4.x label Jul 7, 2023
grafana-delivery-bot bot pushed a commit that referenced this pull request Jul 7, 2023
Interpolate retention policies

(cherry picked from commit f610e37)
itsmylife added a commit that referenced this pull request Jul 7, 2023
InfluxDB: Interpolate retention policies (#69202)

Interpolate retention policies

(cherry picked from commit f610e37)

Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>
@ricky-undeadcoders ricky-undeadcoders removed this from the 10.1.x milestone Aug 1, 2023
@ricky-undeadcoders ricky-undeadcoders added this to the 10.1.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression from 9.3.2: Dashboard-variable not used in Influx-query in 9.5.1
5 participants