Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema: Improve Dashboard kind docs and remove deprecated props #69652

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

ivanortegaalba
Copy link
Contributor

@ivanortegaalba ivanortegaalba commented Jun 6, 2023

Backport 819041c from #69359

Remove unused properties:
  * `FieldColorModeId.PaletteSaturated`: It doesn't exist and it is not a valid palette.
  * `VariableModel.rootStateKey`: It is not persisted in the DB, so it shouldn't be in the schema. It is a property only used in the frontend to store the Redux store key.
  * `VariableModel.error`: It is not persisted in the DB, so it shouldn't be in the schema. It is a property only used in the frontend to store fetching errors.
  * `Panel.thresholds`: old property only existing in previous versions of the dashboard schema.
  * `Panel.timeRegions`: old property only existing in previous versions of the dashboard schema.

(cherry picked from commit 819041c)
@ivanortegaalba ivanortegaalba added add to changelog backport A backport PR area/dashboard/schemas area/schema Related to canonical Grafana entity schemas labels Jun 6, 2023
@ivanortegaalba ivanortegaalba added this to the 10.0.x milestone Jun 6, 2023
@ivanortegaalba ivanortegaalba self-assigned this Jun 6, 2023
@ivanortegaalba ivanortegaalba requested review from a team, grafanabot and Eve832 as code owners June 6, 2023 14:56
@ivanortegaalba ivanortegaalba requested review from polibb, evictorero, joshhunt, ashharrison90 and jackw and removed request for a team June 6, 2023 14:56
@ivanortegaalba ivanortegaalba changed the title Schema: Improve Dashboard kind docs and remove deprecated props (#69359) [v10.0.x] Schema: Improve Dashboard kind docs and remove deprecated props Jun 6, 2023
@ivanortegaalba ivanortegaalba changed the title [v10.0.x] Schema: Improve Dashboard kind docs and remove deprecated props Schema: Improve Dashboard kind docs and remove deprecated props Jun 6, 2023
@ivanortegaalba ivanortegaalba enabled auto-merge (squash) June 6, 2023 15:05
@ivanortegaalba ivanortegaalba enabled auto-merge (squash) June 6, 2023 15:06
@axelavargas axelavargas changed the title Schema: Improve Dashboard kind docs and remove deprecated props [v10.0.x] Schema: Improve Dashboard kind docs and remove deprecated props Jun 6, 2023
Copy link
Member

@axelavargas axelavargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@ivanortegaalba ivanortegaalba changed the title [v10.0.x] Schema: Improve Dashboard kind docs and remove deprecated props Schema: Improve Dashboard kind docs and remove deprecated props Jun 6, 2023
@ivanortegaalba ivanortegaalba merged commit 781a531 into v10.0.x Jun 6, 2023
14 checks passed
@ivanortegaalba ivanortegaalba deleted the backport-69359-to-v10.0.x branch June 6, 2023 17:22
@zerok zerok modified the milestones: 10.0.x, 10.0.1 Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants