Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextPanel: Fix <summary> styling missing the disclosure triangle #70133

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

joshhunt
Copy link
Contributor

Fixes styling of summary/details HTML tags where the the 'disclosure triangle' on the clickable summary was missing.

<summary> should be by default display: list-item (TIL!), where it will get that chevron. The (very old) normalize stylesheet was resetting it's display to block to support old browsers. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details#customizing_the_disclosure_widget

Fixes #69661

@joshhunt joshhunt added no-changelog Skip including change in changelog/release notes backport v10.0.x labels Jun 15, 2023
@joshhunt joshhunt requested a review from a team as a code owner June 15, 2023 09:36
@joshhunt joshhunt requested review from eledobleefe and JoaoSilvaGrafana and removed request for a team June 15, 2023 09:36
@joshhunt joshhunt changed the title TextPanel: Fix <summary> styling TextPanel: Fix <summary> styling missing the disclosure triangle Jun 15, 2023
@joshhunt joshhunt added this to the 10.0.x milestone Jun 15, 2023
@grafana grafana deleted a comment from grafanabot Jun 15, 2023
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏👏👏👏👏

@joshhunt joshhunt merged commit 57d7288 into main Jun 15, 2023
27 of 28 checks passed
@joshhunt joshhunt deleted the joshhunt/details-summary-styling branch June 15, 2023 10:12
grafanabot pushed a commit that referenced this pull request Jun 15, 2023
)

TextPanel: Fix <summary> styling
(cherry picked from commit 57d7288)
joshhunt added a commit that referenced this pull request Jun 15, 2023
…angle (#70138)

TextPanel: Fix <summary> styling missing the disclosure triangle (#70133)

TextPanel: Fix <summary> styling
(cherry picked from commit 57d7288)

Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
@zerok zerok modified the milestones: 10.0.x, 10.0.1, 10.1.x Jun 20, 2023
harisrozajac pushed a commit that referenced this pull request Jun 30, 2023
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text Panel: HTML Details tag doesn't show expander
5 participants