Explore: Improve logs volume panel empty state #70240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking care of this @Elfo404 ! |
|
Backend code coverage report for PR #70240 |
|
Frontend code coverage report for PR #70240
|
3 tasks
grafanabot
pushed a commit
that referenced
this pull request
Jun 16, 2023
(cherry picked from commit 520cd55)
LudoVio
pushed a commit
that referenced
this pull request
Jun 26, 2023
harisrozajac
pushed a commit
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
When no log volume is available in Explore, the lgos volume panel renders without any content:
This PR adds an info instead so that it's more clear for the users to understand why there's no volume graph:
Which issue(s) does this PR fix?:
Fixes #65456
Special notes for your reviewer:
Please check that: