Search: Always send specified kind in sql searcher #70376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tobias Skarhed <tobias.skarhed@gmail.com> Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com> Co-authored-by: joshhunt <josh@trtr.co>
joshhunt
requested review from
ashharrison90 and
JoaoSilvaGrafana
and removed request for
a team
joshhunt
added
no-backport
3 tasks
LudoVio
pushed a commit
that referenced
this pull request
Jun 26, 2023
Co-authored-by: Tobias Skarhed <tobias.skarhed@gmail.com> Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
harisrozajac
pushed a commit
that referenced
this pull request
Jun 30, 2023
Co-authored-by: Tobias Skarhed <tobias.skarhed@gmail.com> Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SQL searcher (search v1) did not send through the kind to the search API as expected. The previous behaviour was unclear to me, and the tests didn't really explain this behaviour (though it did assert it). I've done a bunch of testing and everything still appears to work fine.
Part of #69611