Alerting: Add limit query parameter to Loki-based ASH api, drop default limit from 5000 to 1000, extend visible time range for new ASH UI #70769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexweav
added
area/alerting
|
Hello @alexweav!
Please, if the current pull request addresses a bug fix, label it with the |
armandgrillet
added
the
product-approved
JacobsonMT
approved these changes
Jun 27, 2023
| getRuleHistory: build.query<DataFrameJSON, { ruleUid: string; from: number; to?: number }>({ | ||
| query: ({ ruleUid, from, to = getUnixTime(new Date()) }) => ({ | ||
| getRuleHistory: build.query<DataFrameJSON, { ruleUid: string; from?: number; to?: number; limit?: number }>({ | ||
| query: ({ ruleUid, from, to, limit = 100 }) => ({ |
There was a problem hiding this comment.
why 100 and not 250?
alexweav
changed the title
3 tasks
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Jun 28, 2023
…lt limit from 5000 to 1000, extend visible time range for new ASH UI (#70769) * Add limit query parameter * Drop copy paste comment * Extend history query limit to 30 days and 250 entries * Fix history log entries ordering * Update no history message, add empty history test --------- Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com> (cherry picked from commit f94fb76)
alexweav
added a commit
that referenced
this pull request
Jun 28, 2023
…drop default limit from 5000 to 1000, extend visible time range for new ASH UI (#70857) Alerting: Add limit query parameter to Loki-based ASH api, drop default limit from 5000 to 1000, extend visible time range for new ASH UI (#70769) * Add limit query parameter * Drop copy paste comment * Extend history query limit to 30 days and 250 entries * Fix history log entries ordering * Update no history message, add empty history test --------- Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com> (cherry picked from commit f94fb76) Co-authored-by: Alexander Weaver <weaver.alex.d@gmail.com>
harisrozajac
pushed a commit
that referenced
this pull request
Jun 29, 2023
…lt limit from 5000 to 1000, extend visible time range for new ASH UI (#70769) * Add limit query parameter * Drop copy paste comment * Extend history query limit to 30 days and 250 entries * Fix history log entries ordering * Update no history message, add empty history test --------- Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com>
harisrozajac
pushed a commit
that referenced
this pull request
Jun 30, 2023
…lt limit from 5000 to 1000, extend visible time range for new ASH UI (#70769) * Add limit query parameter * Drop copy paste comment * Extend history query limit to 30 days and 250 entries * Fix history log entries ordering * Update no history message, add empty history test --------- Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Allows clients to configure the record limit when querying loki. You can now supply a
limitquery parameter, with a value between 0 and 5000, to control the size of the returned page. Limits are hard-capped at 5000.The default limit, when the query parameter is not present, has been dropped from 5000 to 1000.
Which issue(s) does this PR fix?:
n/a
Special notes for your reviewer:
Please check that: