Tracing: Remove newTraceViewHeader feature toggle #71818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joey-grafana
added
type/docs
area/explore
area/frontend
add to changelog
area/tracing
datasource/Tempo
no-backport
|
(Open the links below in a new tab to go to the correct steps)
|
grafanabot
added
the
levitate breaking change
|
Backend code coverage report for PR #71818 |
|
Frontend code coverage report for PR #71818
|
joey-grafana
requested review from
grafanabot,
a team,
Eve832,
GrafanaWriter and
lwandz13
as code owners
joey-grafana
requested review from
summerwollin and
dafydd-t
and removed request for
a team
adrapereira
approved these changes
Jul 18, 2023
linoman
pushed a commit
that referenced
this pull request
Jul 24, 2023
* Remove TracePageHeader, uiFind, setTrace and many spanFindMatches * Removed TracePageSearchBar * Update useSearch * Update filterSpans * Update docs * Updated tests * Add trace to tests * Remove feature toggle * Renames in useSearch * Renames in filter-spans * Cleanup fixes * Rename TracePageHeader * Rename TracePageSearchBar * Update test * Update style for long urls * Style and check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Removes the newTraceViewHeader feature toggle.
Why do we need this feature?
To enable the new trace view and span filtering by default.
Who is this feature for?
Tracing users.
Special notes for your reviewer:
Please check that: