[v10.0.x] Alerting: Fix edit / view of webhook contact point when no authorization is set #71972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
grafana-delivery-bot
bot
added
add to changelog
area/alerting
gillesdemey
approved these changes
Jul 19, 2023
|
Is this fixed? I have a case where I am trying to use the webhook URL for a Slack contact point and when i test it, I'm getting the error "Fail to send request POST....unsupported protocol scheme". With version 10.0.2 it works, no problem. Or maybe it is a different issue. |
|
@BogdanRS can confirm the issue you have described on 10.0.3. Using a confirmed working webhook URL (tested via curl) and test leads to an error |
|
confirming the alert works after downgrade to 10.0.2 (docker) , whether or not its specific to this merge there seems to be a regression between .2 and .3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 6d1ff7f from #71965
The
authorizationconfiguration for a webhook is optional, it was incorrectly typed in a91de30 and thus causes a crash when a user tries to view a contact point that included a webhook configuration without theauthorizationproperty.This is mostly limited to alertmanager configurations loaded from a file as creating a webhook receiver via the UI will set an empty
authorizationobject.