SSE: Warn on dropped items in Union in Math Operation #72682
Conversation
| @@ -77,6 +77,8 @@ func (t NodeType) String() string { | |||
| return "NodeString" | |||
| case NodeNumber: | |||
| return "NodeNumber" | |||
| case NodeVar: | |||
There was a problem hiding this comment.
random fix, can go in another PR if this isn't merged
kylebrandt
added
no-backport
kylebrandt
changed the title
| bVar := biNode.Args[1].String() | ||
|
|
||
| aMatched := make([]bool, len(aResults.Values)) | ||
| bMatched := make([]bool, len(bResults.Values)) |
There was a problem hiding this comment.
I think I understand the approach. I wonder if we can hold only indices of the unmatched. In this case, we will not have to pre-allocate slices, which can be pretty big (I've seen 10k dimensions) but act more lazily because dropped metrics are not something that appears often during regular rule evaluation.
This will require no-data case to be handled separately but I think it will help readability.
There was a problem hiding this comment.
This is what I tried at first but ran into difficulty. With the nested loop, we loop over B results multiple times. So during that loop - it is not known if a result will be matched in a future loop. So I ended up creating bool mask where I mark as matched during the loop iteration, and then take the unmatched items.
There was a problem hiding this comment.
LGTM.
Not in this PR, but I think it would be great to have different modes of SSE evals: normal and diagnostics. In the diag mode each node could emit additional information that could be exposed to front-end and presented in some fancy UI. In normal mode it can be evaluated by alerting, so it does not have to spend time on collecting diag info.
|
I think these are erroneously appearing on my Graphite Math. Any way to hide them? See above linked issue for details. |
What is this feature?
Unions in SSE operations currently drop items when doing a binary operation (e.g. $A + $B) from either A or B when there isn't a label "match" between them.
This is confusing, so to aid in this, we warn and display the count of items that where dropped, and which items they were.
Fixes #
Special notes for your reviewer:
Design wise, we really need to revisit "Union". In short, Math should probably have a dropdown that changes what happens with a binary operation (e.g.
$a OP $b) in terms of union/join set operations based on labels. So this is more in the direction of "Informational based on the currently (and only mode)" so as not to create a future problem when tackling this in a broader sense.The output format is pretty dense. The way it works is from Left to Right, so -
((A union B) union C). So things can be dropped between union of A and B, as well as between the result of of the the union between A and B then having a Union with C. To put it another way, with$A + $B + $C, if there is a match between A and C, but not between A and B, the item will be dropped.Please check that: