Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keyboard shotcuts for collapse/expand rows #7538

Closed
wants to merge 1 commit into from

Conversation

mtanda
Copy link
Collaborator

@mtanda mtanda commented Feb 13, 2017

Fixes, #552

I add keyboard shortcuts. Please see following comment.
#7536 (comment)

Copy link
Contributor

@bergquist bergquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

You also need to add the shortcuts to https://github.com/grafana/grafana/blob/master/public/app/core/components/help/help.ts

Will merge once help text is added.

@bergquist
Copy link
Contributor

bergquist commented Feb 22, 2017

I made the changes myself.

Thanks for contributing!

Closed by 5a30b08

@mtanda
Copy link
Collaborator Author

mtanda commented Feb 22, 2017

Sorry, I miss your message.
Thanks for adding the feature!

@perlun
Copy link

perlun commented Oct 3, 2019

Anyone else discovering this a few years later (like me), the shortcuts have now changed to this:

// collapse all rows
this.bind('d shift+c', () => {
dashboard.collapseRows();
});

// expand all rows
this.bind('d shift+e', () => {
dashboard.expandRows();
});

@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants