Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Exclude 32-bit arm builds #75448

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Bug: Exclude 32-bit arm builds #75448

merged 2 commits into from
Sep 29, 2023

Conversation

dsotirakis
Copy link
Contributor

@dsotirakis dsotirakis commented Sep 26, 2023 •
edited
Loading

What is this feature?

Excludes armv6 and armv7 builds for PR, main and downstream pipelines.

Why do we need this feature?

Blocks all enterprise pipelines.

Part of https://github.com/grafana/grafana-delivery/issues/250

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@dsotirakis dsotirakis added type/bug type/ci Tasks related to Continuous Integration workflow no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Sep 26, 2023
@dsotirakis dsotirakis added this to the 10.2.x milestone Sep 26, 2023
@dsotirakis dsotirakis self-assigned this Sep 26, 2023
@dsotirakis dsotirakis force-pushed the exclude-32-bit-arm-builds-go-issue branch from e7fcf90 to 54e9324 Compare September 26, 2023 13:24
@kminehart
Copy link
Contributor

kminehart commented Sep 26, 2023 •
edited
Loading

@dsotirakis you'll need to remove the arm/v7 and arm/v6 distros when calling rgm_package in PR and main pipelines as well. I think that's in build.star?

@dsotirakis dsotirakis marked this pull request as ready for review September 26, 2023 14:36
@dsotirakis dsotirakis requested a review from a team September 26, 2023 14:36
@dsotirakis
Exclude 32 bit arm builds
98422f8 
# Conflicts:
#	pkg/build/config/versions.go
@dsotirakis
Bump grabpl - remove arm/v7 from build.star
9ddbfc7 
# Conflicts:
#	.drone.yml
@dsotirakis dsotirakis force-pushed the exclude-32-bit-arm-builds-go-issue branch from 7c55e8c to 9ddbfc7 Compare September 27, 2023 07:06
@kminehart kminehart merged commit c08606d into main Sep 29, 2023
13 checks passed
@kminehart kminehart deleted the exclude-32-bit-arm-builds-go-issue branch September 29, 2023 17:33
grafana-delivery-bot bot pushed a commit that referenced this pull request Sep 29, 2023
@dsotirakis @kminehart
Bug: Exclude 32-bit arm builds (#75448)
d32201b 
* Exclude 32 bit arm builds

* Bump grabpl - remove arm/v7 from build.star
grafana-delivery-bot bot pushed a commit that referenced this pull request Sep 29, 2023
@dsotirakis @kminehart
Bug: Exclude 32-bit arm builds (#75448)
fb44fe7 
* Exclude 32 bit arm builds

* Bump grabpl - remove arm/v7 from build.star
grafana-delivery-bot bot pushed a commit that referenced this pull request Sep 29, 2023
@dsotirakis @kminehart
Bug: Exclude 32-bit arm builds (#75448)
ac7f9d4 
* Exclude 32 bit arm builds

* Bump grabpl - remove arm/v7 from build.star
bergquist added a commit that referenced this pull request Oct 2, 2023
@bergquist
Merge branch 'main' into instrumentations_enable_native_histogram
54d4ccc 
* main: (51 commits)
  Postgres: Make securejson password optional (#75801)
  Alerting: Manage remote Alertmanager silences (#75452)
  Replace use of `relref` shortcode with `docs/reference` so links work in Grafana Cloud (#75433)
  Add canonical for testing new canonical behavior in Grafana Cloud (#75745)
  InfluxDB SQL: Remove default limitation in the query (#75749)
  Publish documentation from the HEAD of the matching version branch on tag events (#73809)
  IDforwarding: forward signed id to plugins (#75651)
  Navtree: Rename page title from "Infrastructure" to "Integrations" (#75721)
  Changelog: Updated changelog for 9.5.12 (#75776)
  Chore: update latest.json to 10.1.4 (#75773)
  Changelog: Updated changelog for 10.1.4 (#75769)
  Changelog: Updated changelog for 10.0.8 (#75768)
  Tempo: TraceQL results as a spans list (#75660)
  Bug: Exclude 32-bit `arm` builds (#75448)
  Transformations: Fix inconsistent wording of transformation descriptions (#75746)
  i18n: dashboard import page (#75664)
  Fix issue-labeled GitHub Action (#75753)
  Schema: link table panel to the schema definitions (#75671)
  Plugins: Move alias support to plugin json (but still hardcoded) (#75129)
  Sandbox: allow access to window.grafanaBootData for plugins (#75522)
  ...
rwwiv pushed a commit that referenced this pull request Oct 2, 2023
@dsotirakis @rwwiv
Bug: Exclude 32-bit arm builds (#75448)
1c0bddc 
* Exclude 32 bit arm builds

# Conflicts:
#	pkg/build/config/versions.go

* Bump grabpl - remove arm/v7 from build.star

# Conflicts:
#	.drone.yml
mildwonkey pushed a commit that referenced this pull request Oct 4, 2023
@dsotirakis @mildwonkey
Bug: Exclude 32-bit arm builds (#75448)
c44f429 
* Exclude 32 bit arm builds

# Conflicts:
#	pkg/build/config/versions.go

* Bump grabpl - remove arm/v7 from build.star

# Conflicts:
#	.drone.yml
grafana-delivery-bot bot pushed a commit that referenced this pull request Oct 12, 2023
@dsotirakis @zerok
Bug: Exclude 32-bit arm builds (#75448)
f7685ba 
* Exclude 32 bit arm builds

* Bump grabpl - remove arm/v7 from build.star
grafana-delivery-bot bot pushed a commit that referenced this pull request Oct 12, 2023
@dsotirakis @zerok
Bug: Exclude 32-bit arm builds (#75448)
af18760 
* Exclude 32 bit arm builds

* Bump grabpl - remove arm/v7 from build.star
grafana-delivery-bot bot pushed a commit that referenced this pull request Oct 12, 2023
@dsotirakis @zerok
Bug: Exclude 32-bit arm builds (#75448)
586835b 
* Exclude 32 bit arm builds

* Bump grabpl - remove arm/v7 from build.star
grafana-delivery-bot bot pushed a commit that referenced this pull request Oct 12, 2023
@dsotirakis @zerok
Bug: Exclude 32-bit arm builds (#75448)
ada79a7 
* Exclude 32 bit arm builds

* Bump grabpl - remove arm/v7 from build.star
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
grafana-delivery-bot bot pushed a commit that referenced this pull request Nov 14, 2023
@aangelisc
Bug: Exclude 32-bit arm builds (#75448)
7725977 
* Exclude 32 bit arm builds

* Bump grabpl - remove arm/v7 from build.star

# Conflicts:
#	.drone.yml
#	pkg/build/config/versions.go
#	scripts/drone/steps/lib.star
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kminehart kminehart kminehart approved these changes

Assignees

@dsotirakis dsotirakis

Labels
area/backend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes type/bug type/ci Tasks related to Continuous Integration workflow
Projects
None yet
Milestone
10.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dsotirakis @kminehart @zerok