TooltipPlugin2: Raise parent grid item z-index when pinned #76379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeoniya
force-pushed
the
leeoniya/tooltipplugin2-fixes
branch
from
b5e5a81
to
61c449f
Compare
leeoniya
force-pushed
the
leeoniya/tooltipplugin2-fixes
branch
from
61c449f
to
724d698
Compare
leeoniya
requested review from
Clarity-89,
ashharrison90 and
nmarrs
and removed request for
a team
adela-almasan
approved these changes
Oct 12, 2023
leeoniya
added
no-backport
leeoniya
changed the title
leeoniya
changed the title
leeoniya
commented
Oct 12, 2023
| @@ -96,10 +96,12 @@ | |||
| } | |||
|
|
|||
| // Hack for preventing panel menu overlapping. | |||
| .react-grid-item.context-menu-open, | |||
| .react-grid-item.resizing, | |||
There was a problem hiding this comment.
this fixes a prior regression where a panel that's being resized may temporarily go under an adjacent hovered panel when the mouse moves fast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ok, couple things going on here:
in a dashboard grid, ensures that panels containing pinned context menus which extend beyond the panel bounds are drawn over adjacent panels even when not hovered. before this PR:
Peek.2023-10-11.19-16.mp4
with this PR we automatically unpin when there is a mousedown or mouseup outside the pinned menu container. it's similar to what ClickOutsideWrapper.tsx does. this prevents a bunch of bug related to positioning and z-index bug when resizing panels with pinned items, or entering panel edit when a pinned menu exists.
general refactoring/simplification of TooltipPlugin2 to prepare it for merging in of ZoomPlugin, AnnotationEditorPlugin, and PlotTooltipInterpolator