Alerting: Enable feature flag alertingNoDataErrorExecution by default #77242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobsonMT
approved these changes
Oct 27, 2023
yuri-tceretian
deleted the
yuri-tceretian/enable-alertingNoDataErrorExecution
branch
ssama88
pushed a commit
to ssama88/grafana
that referenced
this pull request
Oct 31, 2023
nikimanoledaki
pushed a commit
that referenced
this pull request
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
PR #68142 introduced this feature flag in Grafana 10.3, and it is disabled by default. This PR enables the flag but keeps a way to turn it off.
The flag has been enabled in the cloud for more than a month.
The flag will be deleted in the next minor\major.
Why do we need this feature?
Enable the fix #68142 by default.
Who is this feature for?
Users that have alert rules with the execution of Error\NoData as Alerting\OK.
Please check that: