Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserAuth: clean-up auth entries on update #78377

Merged
merged 5 commits into from
Nov 20, 2023

Conversation

kalleep
Copy link
Contributor

@kalleep kalleep commented Nov 20, 2023

What is this feature?
Because of how generic oauth has worked in the past, before #65902, we can have several copies of a user_auth entry for generic oauth. If we notice that we have updated more than one row we can remove all rows except one for the combination of user_id, auth_module and auth_id

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@kalleep kalleep added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Nov 20, 2023
@kalleep kalleep added this to the 10.3.x milestone Nov 20, 2023
@kalleep kalleep requested a review from a team as a code owner November 20, 2023 10:48
Copy link
Contributor

@gamab gamab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kalleep kalleep force-pushed the kalleep/cleanup-duplicated-user-auth-entries branch from 97aebbd to d725489 Compare November 20, 2023 13:26
@kalleep kalleep merged commit 72db973 into main Nov 20, 2023
14 checks passed
@kalleep kalleep deleted the kalleep/cleanup-duplicated-user-auth-entries branch November 20, 2023 13:58
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants