Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.0.x] Unified Alerting: Set max_attempts to 1 by default #79101

Merged
merged 1 commit into from Dec 5, 2023

Commits on Dec 5, 2023

  1. Unified Alerting: Set max_attempts to 1 by default (#79095)

    * Unified Alerting: Set `max_attempts` to 1 by default
    
    The retry logic for unified alerting has been broken as far as v9.4.x, rather than fixing it in one go and causing a headache to our users with rules putting extra load on their datasources - I think a better approach is to simply set 1 as a default and then let our users change it.
    
    I see two cons with this approach:
    
    - Configuration for legacy to unified alerting cannot be ported over automatically, users will have to manually set `max_attempts` to 3 when migrating.
    - Users expecting to get any sort of retrying (as with legacy alerting) will not have it out of the box and will have to manually edit the configuration.
    
    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    ---------
    
    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    (cherry picked from commit 0c9356a)
    gotjosh authored and grafana-delivery-bot[bot] committed Dec 5, 2023
    Copy the full SHA
    bb9c0b9 View commit details
    Browse the repository at this point in the history