Pyroscope: Add query range to ProfileTypes API call #79574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleks-p
requested review from
Clarity-89 and
L-M-K-B
and removed request for
a team
aleks-p
commented
Dec 15, 2023
Comment on lines
+58
to
+60
| const end = Date.now(); | ||
| const start = end - 24 * 60 * 60 * 1000; // 1 day ago | ||
| dataSource.getProfileTypes(start, end).then((profileTypes) => { |
There was a problem hiding this comment.
@joey-grafana I am not entirely sure if this is a good thing to do and what its impact is
|
Closing as it overlaps with #77523. @bryanhuhta will merge a few improvements into the original PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This change makes the Pyroscope user experience more consistent by making sure the query interval is included in requests to fetch available profile types.
Why do we need this feature?
The feature solves 2 problems:
Who is this feature for?
Users of the Pyroscope datasource in Grafana.
Special notes for your reviewer:
See grafana/pyroscope#2852 for a related Pyroscope change
Please check that: