Logs navigation: derive current page index #80167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanahuckova
approved these changes
Jan 9, 2024
zserge
pushed a commit
that referenced
this pull request
Jan 22, 2024
* Logs navigation: derive current page index * Formatting
s0lesurviv0r
pushed a commit
to s0lesurviv0r/grafana
that referenced
this pull request
Feb 3, 2024
* Logs navigation: derive current page index * Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before these changes, we were using a state variable to hold the current displayed page index, which needed to be updated after a change in any of multiple props and internal state. This approach caused running conditions, depending on the current value of the list of pages, but also was not necessary, as it can be easily calculated at render time, instead of requiring async state updates.
Which issue(s) does this PR fix?:
Escalation 8919.
Special notes for your reviewer:
Please check that the navigation pages are correctly generated, and the current active page is highlighted in the list of pages.