Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.0.x] Annotations: Split cleanup into separate queries and deletes to avoid deadlocks on MySQL #80681

Merged
merged 3 commits into from Jan 17, 2024

Commits on Jan 16, 2024

  1. Annotations: Split cleanup into separate queries and deletes to avoid…

    … deadlocks on MySQL (#80329)
    
    * Split subquery when cleaning annotations
    
    * update comment
    
    * Raise batch size, now that we pay attention to it
    
    * Iterate in batches
    
    * Separate cancellable batch implementation to allow for multi-statement callbacks, add overload for single-statement use
    
    * Use split-out utility in outer batching loop so it respects context cancellation
    
    * guard against empty queries
    
    * Use SQL parameters
    
    * Use same approach for tags
    
    * drop unused function
    
    * Work around parameter limit on sqlite for large batches
    
    * Bulk insert test data in DB
    
    * Refactor test to customise test data creation
    
    * Add test for catching SQLITE_MAX_VARIABLE_NUMBER limit
    
    * Turn annotation cleanup test to integration tests
    
    * lint
    
    ---------
    
    Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>
    (cherry picked from commit 81c45bf)
    alexweav committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    999eea5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    97aa604 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. empty commit to kick actions

    alexweav committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3a70a4e View commit details
    Browse the repository at this point in the history