InfluxDB: Use grafana timeout value for flux queries #81252
Merged
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsmylife
added
datasource/InfluxDB
no-backport
marefr
requested changes
Jan 25, 2024
pkg/tsdb/influxdb/influxdb.go
Outdated
| im instancemgmt.InstanceManager | ||
| features featuremgmt.FeatureToggles | ||
| } | ||
|
|
||
| func ProvideService(httpClient httpclient.Provider, features featuremgmt.FeatureToggles) *Service { | ||
| func ProvideService(cfg *setting.Cfg, httpClient httpclient.Provider, features featuremgmt.FeatureToggles) *Service { |
There was a problem hiding this comment.
You shouldn't use this as a dependency. Rather I think you should read the timeout value from HTTP options retrieved in newInstanceSettings?
There was a problem hiding this comment.
I updated it badee42
rwwiv
pushed a commit
that referenced
this pull request
Jan 25, 2024
* use grafana timeout for flux queries * get timeout from settings * fix test
|
Thanks for the fix! 👍 |
Ukochka
pushed a commit
that referenced
this pull request
Feb 14, 2024
* use grafana timeout for flux queries * get timeout from settings * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Use grafana timeout configuration for flux query calls
Which issue(s) does this PR fix?:
Fixes #29457
Special notes for your reviewer:
Please check that: