Chore: Remove Form usage from alerting config components #81681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarity-89
added
the
no-changelog
Clarity-89
requested review from
gillesdemey,
konrad147 and
soniaAguilarPeiron
and removed request for
a team
41 tasks
joshhunt
reviewed
Feb 12, 2024
gillesdemey
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
I've tested the admin page and that one still works as intended :)
The other files are part of "legacy alerting" which will be removed by the time Grafana 11 lands – the changes there look good code-wise but I haven't tested them.
I'm fine merging the PR as-is 👍
Ukochka
pushed a commit
that referenced
this pull request
Feb 14, 2024
* Chore: Replace InputControl in BaseSettings * Chore: Replace InputControl and FormAPI in OptionElement.tsx * Update ConfigEditor.tsx
Ukochka
pushed a commit
that referenced
this pull request
Feb 14, 2024
* Chore: Replace InputControl in BaseSettings * Chore: Replace InputControl and FormAPI in OptionElement.tsx * Update ConfigEditor.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Removes Form and other deprecated grafana/ui components from
Why do we need this feature?
Part of #81226.