Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove Form usage from notification policies #81758

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

Clarity-89
Copy link
Contributor

What is this feature?

Remove the Form component usage from notification policies.

Why do we need this feature?
Part of the Form deprecation epic.

Which issue(s) does this PR fix?:

Part of #81226

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@Clarity-89 Clarity-89 added the no-changelog Skip including change in changelog/release notes label Feb 2, 2024
@Clarity-89 Clarity-89 added this to the 10.4.x milestone Feb 2, 2024
@Clarity-89 Clarity-89 self-assigned this Feb 2, 2024
@Clarity-89 Clarity-89 requested a review from a team as a code owner February 2, 2024 06:30
@Clarity-89 Clarity-89 requested review from gillesdemey, konrad147 and soniaAguilarPeiron and removed request for a team February 2, 2024 06:31
# Conflicts:
#	public/app/features/alerting/unified/components/notification-policies/EditNotificationPolicyForm.tsx
@Clarity-89
Copy link
Contributor Author

@grafana/alerting-frontend could I get a review on this PR?

Copy link
Member

@soniaAguilarPeiron soniaAguilarPeiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Clarity-89 Clarity-89 merged commit 5132828 into main Feb 21, 2024
14 checks passed
@Clarity-89 Clarity-89 deleted the chore/notification-policies-form branch February 21, 2024 16:14
yuri-tceretian pushed a commit that referenced this pull request Feb 26, 2024
* Chore: Replace Form component usage in EditDefaultPolicyForm.tsx

* Chore: Replace Form component usage in EditNotificationPolicyForm.tsx

* Remove ts-ignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend no-changelog Skip including change in changelog/release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants