TimeSeries: Don't re-init chart with bars style on data updates #83355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeoniya
added
type/bug
type/performance
area/panel/timeseries
nmarrs
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63247
we were unintentionally re-initializing TimeSeries charts that contained bars-style series as a result of needing to customize how null values are handled when joining the dataset. we were modifying
field.config.custom.spanNullsto a magic value, which caused the schema diff to increment thestructureRevand force re-init with every data update.this PR removes the use of mutation and magic value, replacing it with an extra option to the join transformer that allows customizing the null-values behavior on a per-field basis, allowing us to keep the original schema intact for a clean diff.