New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular deprecation: Dashboards: Add link to auto-migrate compatible panels to dashboard warning #83394
Conversation
Hello @xnyo!
Please, if the current pull request addresses a bug fix, label it with the |
Hi @xnyo, at DataViz team we are trying to put together a script (guidelines) to use when communicating with customers about the expected deprecations and how to safely test the auto migration. There are few things we need to understand:
|
The link displayed in the screenshot is shown in a warning that's displayed at the top of dashboards that use Angular plugins. This warning is displayed since Grafana 10.4.0. The "Auto-migrate compatible panels" link in particular will be displayed when the dashboard contains at least one of the following plugins:
Here's a better screenshot showing it:
I don't know the details regarding the auto migration feature, but from my testing the dashboard required a manual save before the migration was committed. So there's no option to revert the auto migration because it has to be saved manually by the user |
yes, once it is saved there is no going back, unless you restore old database or if we offer a built-in way to undo db changes (such as retaining old versions somewhere else in the db). but this will only work until angular is removed anyhow. i think the main issue with the inability to use a url for feature enablement in production environments is that to "undo" an unsaved migration is no longer a browser Back button away. we need to provide a way to clear the appropriate cookie or localStorage variable that we choose to implement instead of simply relying on browser url history. |
the dashboard.json is stored in the db. so if we already offer some way to restore previous dashboard versions, then sure. this is outside my wheelhouse. idk what we offer in terms of backend storage capabilities or how/where we expose this in the UI. EDIT: yeah, i guess it exists :) https://grafana.com/docs/grafana/latest/dashboards/build-dashboards/manage-version-history/ |
Superseded by #84100 |
This PR must be merged before a backport PR will be created. |
What is this feature?
Adds a link to Angular dashboard warnings that points to
&__feature.autoMigrateOldPanels=true
.It is be displayed only when the dashboard contains panels that can be migrated.
Requires #84034 to be merged before this PR, in order to set the feature flag from URL in production mode.
Why do we need this feature?
Simplify auto-migrating Angular panels.
Who is this feature for?
Grafana users with Angular panel plugins.
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Need to add more tests
Please check that: