Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerting: Stop persisting user-defined templates to disk #83456

Merged
merged 9 commits into from
Mar 4, 2024
Merged

Alerting: Stop persisting user-defined templates to disk #83456

merged 9 commits into from
Mar 4, 2024

Commits on Mar 4, 2024

  1. Update grafana/alerting to temporary commit ref

    @JacobsonMT
    JacobsonMT committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    12ade75 View commit details
    Browse the repository at this point in the history

  2. Remove Config template filenames for PostableUserConfig template strings

    @JacobsonMT
    JacobsonMT committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    1ab12cb View commit details
    Browse the repository at this point in the history

  3. Use PostableUserConfig hash to check for AM config changes 

    Previously we relied on templates files on disk to check for template changes.
Now that we no longer have those, we must rely on the configuration itself.
Since PostableApiAlertingConfig does not include template strings, we use
PostableUserConfig instead.
    @JacobsonMT
    JacobsonMT committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    3705297 View commit details
    Browse the repository at this point in the history

  4. Add back Templates field to PostableApiAlertingConfig for external AMs

    @JacobsonMT
    JacobsonMT committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    84b0225 View commit details
    Browse the repository at this point in the history

  5. Add info log when alertmanager applies a changed config

    @JacobsonMT
    JacobsonMT committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    ce34ecd View commit details
    Browse the repository at this point in the history

  6. Update to latest grafana/alerting temporary ref

    @JacobsonMT
    JacobsonMT committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    de840e8 View commit details
    Browse the repository at this point in the history

  7. Update to latest grafana/alerting temporary ref

    @JacobsonMT
    JacobsonMT committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    e5ee87d View commit details
    Browse the repository at this point in the history

  8. Set configHash directly to be inline with other fields

    @JacobsonMT
    JacobsonMT committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    a3ba88d View commit details
    Browse the repository at this point in the history

  9. Update to final grafana/alerting ref

    @JacobsonMT
    JacobsonMT committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    dc31023 View commit details
    Browse the repository at this point in the history