Alerting: Remove concurrent_render_limit in legacy alerting #83775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuri-tceretian
added
area/alerting
yuri-tceretian
requested review from
torkelo,
a team and
chri2547
as code owners
yuri-tceretian
requested review from
rwwiv,
JacobsonMT,
grobinson-grafana,
papagian,
zserge and
suntala
and removed request for
a team
replace it with global limit in the headless screenshot service
yuri-tceretian
force-pushed
the
yuri-tceretian/concurrent_render_limit
branch
from
ee7ee65
to
945e1ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR is a part of the efforts to remove the deprecated alerting. It removes a setting
[alerting].concurrent_render_limit. The setting was used in HeadlessScreenshotService, which is used by the Unified Alerting screenshot service with its own rate-limiting mechanism. Therefore, I chose to replace the setting with the global setting[rendering].concurrent_render_request_limitwhose default value is 30.Why do we need this feature?
Remove legacy alerting.
Who is this feature for?
This change should not affect anyone.
Which issue(s) does this PR fix?:
Contributes to #81268
Special notes for your reviewer:
Please check that: