New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canvas: Add mode that enables one click data link access #85430
Conversation
builder.addBooleanSwitch({ | ||
path: 'quickDataLinkAccess', | ||
name: 'Quick data link access', | ||
description: 'Enable one click access to data links for elements with a single data link', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: 'Enable one click access to data links for elements with a single data link', | |
description: 'Enable one click data links for elements with a single data link', |
Perhaps this can be re-worded a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected, other than considering some rewording, LGTM!
@@ -74,6 +74,7 @@ export class Scene { | |||
currentLayer?: FrameState; | |||
isEditingEnabled?: boolean; | |||
shouldShowAdvancedTypes?: boolean; | |||
isQuickDataLinkAccessEnabled?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nitpick but this would is a bit of a mouthful name wise. Maybe something like quickDataLinksEnabled
or something like that 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested out and looks good! Only have a nitpick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deeeeee-lish. 👍
please hold off on merging this. let's make sure we coordinate this functionality across all panels so it is in a consistent location. we have a similar ask for TimeSeries and other panels that support data links: #79479 |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions! |
Closing this in favor of figuring out a universal one click data link access solution, see #87945 |
This is a pretty common community request (see here and here) and an impactful quality of life improvement.
For now, added a global toggle that enables a "quick data link access mode" that allows users to navigate to a data link in one seamless click vs messing with the tooltip. This only works for elements that have only one data link configured, else the tooltip mode will still be used.
one.click.data.link.access.in.canvas.mov
Test dashboard is this local gdev dashboard
Fixes #79698
Fixes #77246