Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas: Add mode that enables one click data link access #85430

Closed
wants to merge 1 commit into from

Conversation

nmarrs
Copy link
Contributor

@nmarrs nmarrs commented Apr 1, 2024

This is a pretty common community request (see here and here) and an impactful quality of life improvement.

For now, added a global toggle that enables a "quick data link access mode" that allows users to navigate to a data link in one seamless click vs messing with the tooltip. This only works for elements that have only one data link configured, else the tooltip mode will still be used.

one.click.data.link.access.in.canvas.mov

Test dashboard is this local gdev dashboard

Fixes #79698
Fixes #77246

@nmarrs nmarrs added area/panel/canvas Issues related to canvas panel no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Apr 1, 2024
@nmarrs nmarrs added this to the 11.0.x milestone Apr 1, 2024
@nmarrs nmarrs self-assigned this Apr 1, 2024
@nmarrs nmarrs requested a review from a team as a code owner April 1, 2024 08:15
@nmarrs nmarrs requested review from baldm0mma and drew08t and removed request for a team April 1, 2024 08:15
@grafana-delivery-bot grafana-delivery-bot bot modified the milestones: 11.0.x, 11.1.x Apr 1, 2024
@nmarrs nmarrs modified the milestones: 11.1.x, 11.0.x Apr 1, 2024
builder.addBooleanSwitch({
path: 'quickDataLinkAccess',
name: 'Quick data link access',
description: 'Enable one click access to data links for elements with a single data link',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: 'Enable one click access to data links for elements with a single data link',
description: 'Enable one click data links for elements with a single data link',

Perhaps this can be re-worded a bit.

Copy link
Contributor

@drew08t drew08t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, other than considering some rewording, LGTM!

@nmarrs nmarrs requested a review from lukasztyrala April 1, 2024 17:27
@@ -74,6 +74,7 @@ export class Scene {
currentLayer?: FrameState;
isEditingEnabled?: boolean;
shouldShowAdvancedTypes?: boolean;
isQuickDataLinkAccessEnabled?: boolean;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nitpick but this would is a bit of a mouthful name wise. Maybe something like quickDataLinksEnabled or something like that 😄

Copy link
Collaborator

@codeincarnate codeincarnate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out and looks good! Only have a nitpick

Copy link
Contributor

@baldm0mma baldm0mma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deeeeee-lish. 👍

@leeoniya
Copy link
Contributor

leeoniya commented Apr 2, 2024

please hold off on merging this.

let's make sure we coordinate this functionality across all panels so it is in a consistent location.

we have a similar ask for TimeSeries and other panels that support data links: #79479

Copy link
Contributor

github-actions bot commented May 2, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions!

@github-actions github-actions bot added the stale Issue with no recent activity label May 2, 2024
@leeoniya leeoniya removed the stale Issue with no recent activity label May 2, 2024
@fabrizio-grafana fabrizio-grafana modified the milestones: 11.0.x, 11.1.x May 13, 2024
@nmarrs
Copy link
Contributor Author

nmarrs commented May 15, 2024

Closing this in favor of figuring out a universal one click data link access solution, see #87945

@nmarrs nmarrs closed this May 15, 2024
@grafana-delivery-bot grafana-delivery-bot bot removed this from the 11.1.x milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend area/panel/canvas Issues related to canvas panel no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
6 participants