Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canvas: Update new element type with rotation #85690

Merged
merged 5 commits into from
Apr 11, 2024
Merged

Canvas: Update new element type with rotation #85690

merged 5 commits into from
Apr 11, 2024

Conversation

adela-almasan
Copy link
Contributor

@adela-almasan adela-almasan commented Apr 5, 2024 •
edited

rotation.mov

Fixes #84959
Fixes #84958

Special notes for your reviewer:

  • About rotation handler and dimension ables overlapping: I chose to add 2 rotation handlers and that should cover all cases. Before that I tried to move the dimension ables closer to the element and there were some angles where they were overlapping. Having the ables farther away from the element doesn't look great. It might need more investigation and trial and error to figure out the best case. cc @lukasztyrala

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@adela-almasan adela-almasan added type/bug area/panel/canvas Issues related to canvas panel no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes bug-bash labels Apr 5, 2024
@adela-almasan adela-almasan added this to the 11.0.x milestone Apr 5, 2024
@adela-almasan adela-almasan self-assigned this Apr 5, 2024
@adela-almasan adela-almasan requested a review from a team as a code owner April 5, 2024 22:38
@adela-almasan adela-almasan requested review from nmarrs and baldm0mma and removed request for a team April 5, 2024 22:38
baldm0mma
baldm0mma approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@baldm0mma baldm0mma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked great for me! How do you plan on handling the connection arrows?

@adela-almasan adela-almasan merged commit eb86fd8 into main Apr 11, 2024
14 checks passed
@adela-almasan adela-almasan deleted the canvas_selection_box branch April 11, 2024 20:36
@grafana-delivery-bot grafana-delivery-bot bot modified the milestones: 11.0.x, 11.1.x Apr 11, 2024
lingyufei pushed a commit to lingyufei/grafana that referenced this pull request Apr 12, 2024
@adela-almasan @lingyufei
Canvas: Update new element type with rotation (grafana#85690)
880398c
reemtariqq pushed a commit that referenced this pull request Apr 12, 2024
@adela-almasan @reemtariqq
Canvas: Update new element type with rotation (#85690)
2176b73
@adela-almasan adela-almasan mentioned this pull request Apr 12, 2024
Closed
@nmarrs nmarrs mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baldm0mma baldm0mma baldm0mma approved these changes

@nmarrs nmarrs Awaiting requested review from nmarrs nmarrs is a code owner automatically assigned from grafana/dataviz-squad

Assignees

@adela-almasan adela-almasan

Labels
area/frontend area/panel/canvas Issues related to canvas panel bug-bash no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes type/bug
Projects
None yet
Milestone
11.1.x
2 participants
@adela-almasan @baldm0mma