Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeSeries: Fix series rendering with data links and extra fields #86007

Merged
merged 4 commits into from
Apr 12, 2024
Merged

TimeSeries: Fix series rendering with data links and extra fields #86007

merged 4 commits into from
Apr 12, 2024

Conversation

leeoniya
Copy link
Contributor

@leeoniya leeoniya commented Apr 12, 2024 •
edited
Loading

Fixes https://github.com/grafana/support-escalations/issues/10030

caused by logic change in #85260 which erroneously leaves unwanted/non-renderable fields instead of filtering them out of the joined frame.

@leeoniya leeoniya added type/bug area/panel/timeseries The main time series Graph panel type/regression no-changelog Skip including change in changelog/release notes backport v11.0.x Mark PR for automatic backport to v11.0.x labels Apr 12, 2024
@leeoniya leeoniya added this to the 11.1.x milestone Apr 12, 2024
@leeoniya leeoniya self-assigned this Apr 12, 2024
@leeoniya leeoniya requested a review from a team as a code owner April 12, 2024 03:32
@leeoniya leeoniya requested review from Develer and baldm0mma and removed request for a team April 12, 2024 03:32
@grafana-delivery-bot grafana-delivery-bot
Copy link
Contributor

This PR must be merged before a backport PR will be created.

1 similar comment
@grafana-delivery-bot grafana-delivery-bot
Copy link
Contributor

This PR must be merged before a backport PR will be created.

@leeoniya leeoniya enabled auto-merge (squash) April 12, 2024 12:09
@leeoniya leeoniya merged commit 2bedbcf into main Apr 12, 2024
15 checks passed
@leeoniya leeoniya deleted the leeoniya/timeseries-fix-text-field-datalinks branch April 12, 2024 12:11
grafana-delivery-bot bot pushed a commit that referenced this pull request Apr 12, 2024
@leeoniya @grafana-delivery-bot
TimeSeries: Fix series rendering with data links and extra fields (#8…
a8e11a9 
…6007)

(cherry picked from commit 2bedbcf)
@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request Apr 12, 2024
Merged
leeoniya added a commit that referenced this pull request Apr 12, 2024
@grafana-delivery-bot @leeoniya
[v11.0.x] TimeSeries: Fix series rendering with data links and extra …
8eef690 
…fields (#86044)

TimeSeries: Fix series rendering with data links and extra fields (#86007)

(cherry picked from commit 2bedbcf)

Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
@kevinwcyu kevinwcyu modified the milestones: 11.1.x, 11.1.0 Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaydelaney kaydelaney kaydelaney approved these changes

@Develer Develer Awaiting requested review from Develer Develer is a code owner automatically assigned from grafana/dataviz-squad

@baldm0mma baldm0mma Awaiting requested review from baldm0mma baldm0mma is a code owner automatically assigned from grafana/dataviz-squad

Assignees

@leeoniya leeoniya

Labels
area/frontend area/panel/timeseries The main time series Graph panel backport v11.0.x Mark PR for automatic backport to v11.0.x no-changelog Skip including change in changelog/release notes type/bug type/regression
Projects
None yet
Milestone
11.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leeoniya @kaydelaney @kevinwcyu