Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana UI: LoginPage - Replace HorizontalGroup with Stack #86068

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

eledobleefe
Copy link
Contributor

What is this feature?
This is part of the epic #85510

Why do we need this feature?
To replace deprecated layout components with new ones.

Who is this feature for?
Everybody

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@eledobleefe eledobleefe added area/frontend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Apr 12, 2024
@eledobleefe eledobleefe self-assigned this Apr 12, 2024
@eledobleefe eledobleefe requested review from grafanabot and a team as code owners April 12, 2024 16:17
@eledobleefe eledobleefe requested review from joshhunt and tskarhed and removed request for a team April 12, 2024 16:17
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone Apr 12, 2024
@eledobleefe eledobleefe modified the milestone: 11.1.x Apr 12, 2024
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@eledobleefe eledobleefe merged commit 2b62167 into main Apr 15, 2024
24 checks passed
@eledobleefe eledobleefe deleted the eledobleefe/deprecated-components-login-page branch April 15, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
Status: 🚀 Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants