Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grafana UI: Checkbox.story.tsx - Replace VerticalGroupwith Stack #86524

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Grafana UI: Checkbox.story.tsx - Replace VerticalGroupwith Stack #86524

merged 5 commits into from
Apr 18, 2024

Conversation

eledobleefe
Copy link
Contributor

What is this feature?
This is part of the epic #85510

Why do we need this feature?
To replace deprecated layout components with new ones.

Who is this feature for?
Everybody

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:
Before:
Captura de pantalla 2024-04-18 a las 15 51 28
Captura de pantalla 2024-04-18 a las 15 52 31

After:
Captura de pantalla 2024-04-18 a las 15 52 44
Captura de pantalla 2024-04-18 a las 15 53 04

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@eledobleefe eledobleefe added area/frontend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes saga design system Issues related to the work of the Saga Design System labels Apr 18, 2024
@eledobleefe eledobleefe added this to the 11.1.x milestone Apr 18, 2024
@eledobleefe eledobleefe self-assigned this Apr 18, 2024
@eledobleefe eledobleefe requested review from grafanabot and a team as code owners April 18, 2024 13:53
@eledobleefe eledobleefe requested review from Clarity-89 and ashharrison90 and removed request for a team April 18, 2024 13:53
@eledobleefe eledobleefe mentioned this pull request Apr 18, 2024
Open
43 tasks
@eledobleefe eledobleefe merged commit e65669b into main Apr 18, 2024
17 checks passed
@eledobleefe eledobleefe deleted the eledobleefe/deprecated-layout-checkbox branch April 18, 2024 15:05
@kevinwcyu kevinwcyu modified the milestones: 11.1.x, 11.1.0 Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clarity-89 Clarity-89 Clarity-89 approved these changes

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

@ashharrison90 ashharrison90 Awaiting requested review from ashharrison90 ashharrison90 is a code owner automatically assigned from grafana/grafana-frontend-platform

Assignees

@eledobleefe eledobleefe

Labels
area/frontend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes saga design system Issues related to the work of the Saga Design System
Projects
Grafana Frontend Platform
Status: 🚀 Done
Milestone
11.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eledobleefe @Clarity-89 @kevinwcyu