Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerting: Fix datasource TLS options are ignored #86787

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Alerting: Fix datasource TLS options are ignored #86787

wants to merge 6 commits into from
+277 −211

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Apr 23, 2024 •
edited

Which issue(s) does this PR fix?:

This commit fixes a bug where datasource TLS options are ignored when sending alerts from Grafana to an External Alertmanager.

Fixes #66238

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone Apr 23, 2024
@grobinson-grafana grobinson-grafana requested review from a team, rwwiv, JacobsonMT, yuri-tceretian, JohnnyQQQQ, alexweav, santihernandezc and stevesg and removed request for a team April 23, 2024 14:36
@grobinson-grafana grobinson-grafana self-assigned this Apr 23, 2024
@grobinson-grafana
Alerting: Fix datasource TLS options are ignored
6b41a94 
This commit fixes a bug where datasource TLS options are ignored
when sending alerts from Grafana to an External Alertmanager.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwwiv rwwiv Awaiting requested review from rwwiv rwwiv is a code owner automatically assigned from grafana/alerting-backend-product

@JacobsonMT JacobsonMT Awaiting requested review from JacobsonMT JacobsonMT is a code owner automatically assigned from grafana/alerting-backend-product

@yuri-tceretian yuri-tceretian Awaiting requested review from yuri-tceretian yuri-tceretian is a code owner automatically assigned from grafana/alerting-backend-product

@JohnnyQQQQ JohnnyQQQQ Awaiting requested review from JohnnyQQQQ JohnnyQQQQ was automatically assigned from grafana/alerting-backend-multitenancy

@alexweav alexweav Awaiting requested review from alexweav alexweav was automatically assigned from grafana/alerting-backend-multitenancy

@santihernandezc santihernandezc Awaiting requested review from santihernandezc santihernandezc was automatically assigned from grafana/alerting-backend-multitenancy

@stevesg stevesg Awaiting requested review from stevesg stevesg was automatically assigned from grafana/alerting-backend-multitenancy

At least 1 approving review is required to merge this pull request.

Assignees

@grobinson-grafana grobinson-grafana

Labels
area/backend
Projects
Alerting
Status: In review
Milestone
11.1.x
Development

Successfully merging this pull request may close these issues.

Grafana external Alertmanager datasource Skip TLS Verify or CA Cert options not working
1 participant
@grobinson-grafana