Snapshots: Prevent creation of snapshot of nonexistent dashboard #86806
+66
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_prevent_viewer_deletion
lucychen-grafana
requested review from
juanicabanas and
evictorero
and removed request for
a team
lucychen-grafana
added
no-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Snapshots can be created through API with a dashboard that does NOT exists in the current org. The created snapshot link does not since the dashboard does not exist. A validation check to make sure the dashboard exists is added before snapshot can be created
Why do we need this feature?
To prevent creation of broken snapshots through API
Who is this feature for?
Users who create snapshots through API
Which issue(s) does this PR fix?:
Fixes ##86705
Special notes for your reviewer:
Please check that: