Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloudwatch: Add Kendra metrics #86809

Merged
merged 4 commits into from
May 31, 2024
Merged

Cloudwatch: Add Kendra metrics #86809

merged 4 commits into from
May 31, 2024

Conversation

scottschreckengaust
Copy link
Contributor

What is this feature?
Adds Kendra metric constants.

Why do we need this feature?
The metrics for Kendra are missing.

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #86808

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@CLAassistant
Copy link

CLAassistant commented Apr 23, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions!

@github-actions github-actions bot added the stale Issue with no recent activity label May 30, 2024
@scottschreckengaust scottschreckengaust marked this pull request as ready for review May 30, 2024 19:41
@scottschreckengaust scottschreckengaust requested a review from a team as a code owner May 30, 2024 19:41
@scottschreckengaust scottschreckengaust requested review from iwysiu and sarahzinger and removed request for a team May 30, 2024 19:41
@scottschreckengaust scottschreckengaust changed the title Dashboard: add Kendra metrics Dashboard: Add Kendra metrics May 30, 2024
@scottschreckengaust
Copy link
Contributor Author

Hello @sarahzinger or other reviewers, I cannot apply the no-changelog or add to changelog labels or remove the stale comment. Would you be able to help with that please? Thank you.

@github-actions github-actions bot removed the stale Issue with no recent activity label May 31, 2024
@sarahzinger sarahzinger added this to the 11.1.x milestone May 31, 2024
sarahzinger
sarahzinger approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@sarahzinger sarahzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@sarahzinger sarahzinger changed the title Dashboard: Add Kendra metrics Cloudwatch: Add Kendra metrics May 31, 2024
@sarahzinger sarahzinger merged commit 3e872bb into grafana:main May 31, 2024
34 checks passed
miguelmolina95 pushed a commit to miguelmolina95/grafana that referenced this pull request Jun 3, 2024
@scottschreckengaust @miguelmolina95
Cloudwatch: Add Kendra metrics (grafana#86809)
6a7ff86
@scottschreckengaust scottschreckengaust deleted the feature/kendra-metrics branch June 5, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahzinger sarahzinger sarahzinger approved these changes

@iwysiu iwysiu Awaiting requested review from iwysiu iwysiu is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
add to changelog area/backend datasource/CloudWatch pr/external This PR is from external contributor
Projects
None yet
Milestone
11.1.x
Development

Successfully merging this pull request may close these issues.

Add Amazon Kendra in the Namespace pull-down for CloudWatch metrics
3 participants
@scottschreckengaust @CLAassistant @sarahzinger